fix: Ensure renderEmtpyState is properly displayed in V3 TableView #8416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
| let empty = new LayoutInfo('empty', 'empty', rect); | ||
| empty.parentKey = layoutInfo.key; | ||
| empty.isSticky = true; | ||
| empty.allowOverflow = true; |
There was a problem hiding this comment.
had we accidentally removed this? or what happened? the issue looks familiar, so just want to make sure we aren't reintroducing some other issue
There was a problem hiding this comment.
from what I could tell via my digging, I think we just accidentally removed it. This break originates from this larger refactor: #6451 (and specifically https://github.com/adobe/react-spectrum/pull/6451/files#diff-d0c8a9ca3c72c8c8d461ad870324b199b779e399511a4aab54eb42ce3472820eL288-L293 I think) which had other similar overflow fixes caught and fixed via #6711. This specific one seems to have slipped through the cracks
snowystinger
approved these changes
Jun 18, 2025
reidbarber
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in slack
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP